[PATCH] D48354: [LoopIdiomRecognize] Support for loops that use LSHR instruction added.

[Olga Moldovanova via Phabricator via llvm-commits]

ovmold updated this revision to Diff 152590.
ovmold added a comment.

> - Would you mind re-upping this with full context?

Diff with full context re-upped.

> - Could you clang-format your changes (not necessarily the entire file)?

Done.

> - Also, the below condition would not be necessary for LShr:
> 
>   // Make sure the initial value can't be negative otherwise the ashr in the // loop might never reach zero which would make the loop infinite. // TODO: Support loops that use lshr and wouldn't need this check. if (!isKnownNonNegative(InitX, *DL)) return false;

This has been already done by the first patch. In the current patch it is also present.


Repository:
  rL LLVM

https://reviews.llvm.org/D48354

Files:
  lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  test/Transforms/LoopIdiom/X86/ctlz.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48354.152590.patch
Type: text/x-patch
Size: 8946 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180623/41ab5602/attachment.bin>