[PATCH] D48354: [LoopIdiomRecognize] Support for loops that use LSHR instruction added.
bryant via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 23 02:38:19 PDT 2018
bryant added a comment.
- Would you mind re-upping this with full context?
- Could you clang-format your changes (not necessarily the entire file)?
- Also, the below condition would not be necessary for LShr:
// Make sure the initial value can't be negative otherwise the ashr in the
// loop might never reach zero which would make the loop infinite.
// TODO: Support loops that use lshr and wouldn't need this check.
if (!isKnownNonNegative(InitX, *DL))
return false;
Repository:
rL LLVM
https://reviews.llvm.org/D48354
More information about the llvm-commits
mailing list