[PATCH] D48128: [ARM] Parallel DSP IR Pass

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:259
+    LLVM_DEBUG(dbgs() << "OK: loads are consecutive.\n");
+    return true;
+  }
----------------
efriedma wrote:
> Do you need to check that the memory isn't modified between the two loads?
Yes, we check this a bit earlier with AreNoAliases() in CreateParallelMACPairs().
The store and alias checks are tested in tests smlad6.ll and smlad7.ll, but please let me know if I've missed something here.


https://reviews.llvm.org/D48128