[PATCH] D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 21 14:10:28 PDT 2018
efriedma added inline comments.
================
Comment at: include/llvm/CodeGen/MachineOutliner.h:152
+ std::for_each((MachineBasicBlock::reverse_iterator)front(), MBB->rend(),
+ [this](MachineInstr &MI) { LRU.stepBackward(MI); });
+ }
----------------
This isn't using stepBackward correctly... you have to start from the end of the block to get correct results. I'm surprised this somehow works with your testcases; you probably need a bit better test coverage.
https://reviews.llvm.org/D47655
More information about the llvm-commits
mailing list