[PATCH] D47655: [MachineOutliner] Don't outline sequences where x16/x17/nzcv are live across

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

Ping! :)



================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:4957
+  // candidates.
+  auto CantGuaranteeValueAcrossCall = [](outliner::Candidate &C) {
+    LiveRegUnits LRU = C.LRU;
----------------
Gerolf wrote:
> Could this be abstracted behind a target-specific interface? Other platforms like x86 etc will have to take care of similar issues and an interface would make this explicit. This could be done in a follow-up commit though. 
Yeah, I think it would be a good idea to have targets implement their own version of MachineOutliner.h in general. Then functions like this could be holed away in there. I'll do that in a follow-up.


https://reviews.llvm.org/D47655