[PATCH] D48271: [llvm-readobj] Fix printing format

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/tools/llvm-readobj/print-section.test:1-19
+RUN: llvm-readobj -p .strtab %p/Inputs/elf-groups.x86_64 \
+RUN:     | FileCheck %s
+
+CHECK: [000001] _ZNKSt9type_info4nameEv
+CHECK: [000019] _ZNSt8ios_base4InitD1Ev
+CHECK: [000031] _ZNSt8ios_base4InitC1Ev
+CHECK: [000049] _ZSt4cout
----------------
paulsemel wrote:
> dblaikie wrote:
> > Is any of this testing/demonstrating the unprintable character support? It doesn't immediately look like it to me? (I'm guessing/would be expecting some "...." sort of regions)
> No, but I'm not sure that it really makes sense to have such a test, as it would result to :
>    - Form a not realistic binary
>    - Dump a binary section and have a LOT (almost every) of unprintable characters
>  What do you think ?
Yep, dumping a non-textual section. But it could be a small section - or a manually created section (built from assembly with some text and non-text).

This test would pass with or without your change - so that's not sufficient to validate that this change has the intended effect.


Repository:
  rL LLVM

https://reviews.llvm.org/D48271