[PATCH] D48271: [llvm-readobj] Fix printing format

[Paul Semel via Phabricator via llvm-commits]

paulsemel added inline comments.


================
Comment at: test/tools/llvm-readobj/print-section.test:1-19
+RUN: llvm-readobj -p .strtab %p/Inputs/elf-groups.x86_64 \
+RUN:     | FileCheck %s
+
+CHECK: [000001] _ZNKSt9type_info4nameEv
+CHECK: [000019] _ZNSt8ios_base4InitD1Ev
+CHECK: [000031] _ZNSt8ios_base4InitC1Ev
+CHECK: [000049] _ZSt4cout
----------------
dblaikie wrote:
> Is any of this testing/demonstrating the unprintable character support? It doesn't immediately look like it to me? (I'm guessing/would be expecting some "...." sort of regions)
No, but I'm not sure that it really makes sense to have such a test, as it would result to :
   - Form a not realistic binary
   - Dump a binary section and have a LOT (almost every) of unprintable characters
 What do you think ?


Repository:
  rL LLVM

https://reviews.llvm.org/D48271