[PATCH] D47736: AMDHSA Code Object v3 assembler syntax update

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:2760
+    if (ID == ".amdhsa_group_segment_fixed_size") {
+      if (!isUInt<sizeof(KD.group_segment_fixed_size)>(Val))
+        return OutOfRangeError(ValRange);
----------------
sizeof returns number of bytes. isUint (and similar) take in number of bits.


https://reviews.llvm.org/D47736