[PATCH] D48183: [WebAssembly] Modified tablegen defs to have 2 parallel instuction sets.

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrFormats.td:15
 
 // WebAssembly Instruction Format.
+class WebAssemblyInst<bits<32> inst, string asmstr, bit stack> : Instruction {
----------------
There should probably be a bit more explanation here, saying that every instruction has the 2 representations, how they are used, how the oops/iops and asmstrings need to be different, the naming convention, etc.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrMemory.td:467
+                    Requires<[HasAddr32]>;
+// FIXME: add $flags to first asmstr.
+defm CURRENT_MEMORY_I32 : I<(outs I32:$dst), (ins i32imm:$flags),
----------------
The real FIXME is to just remove CURRENT_MEMORY and GROW_MEMORY altogether (they are the old names) assuming we can remove any uses from e.g. Rust and clang.


Repository:
  rL LLVM

https://reviews.llvm.org/D48183