[PATCH] D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27

[Peter Wu via Phabricator via llvm-commits]

Lekensteyn marked 2 inline comments as done.
Lekensteyn added a comment.

Thanks for the reviews, I fixed both typos in r334719 and disabled the test due to a lit problem on Windows. I'll be looking at supporting glob patterns for commands in general or just the "cd" builtin.

Failing test: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30093

  ******************** TEST 'AddressSanitizer-i386-windows :: TestCases/long-object-path.cc' FAILED ********************
  Exception during script execution:
  Traceback (most recent call last):
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\run.py", line 202, in _execute_test_impl
      result = test.config.test_format.execute(test, lit_config)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\formats\shtest.py", line 25, in execute
      self.execute_external)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 1576, in executeShTest
      res = _runShTest(test, litConfig, useExternalSh, script, tmpBase)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 1524, in _runShTest
      res = executeScriptInternal(test, litConfig, tmpBase, script, execdir)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 1019, in executeScriptInternal
      exitCode, timeoutInfo = executeShCmd(cmd, shenv, results, timeout=litConfig.maxIndividualTestTime)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 163, in executeShCmd
      finalExitCode = _executeShCmd(cmd, shenv, results, timeoutHelper)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 738, in _executeShCmd
      res = _executeShCmd(cmd.rhs, shenv, results, timeoutHelper)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 721, in _executeShCmd
      return _executeShCmd(cmd.rhs, shenv, results, timeoutHelper)
    File "C:/b/slave/sanitizer-windows/llvm\utils\lit\lit\TestRunner.py", line 852, in _executeShCmd
      is_builtin_cmd = args[0] in builtin_commands;
  TypeError: unhashable instance

Reproducible on Linux with the environment variable `LIT_USE_INTERNAL_SHELL=1` set.


Repository:
  rL LLVM

https://reviews.llvm.org/D47995