[PATCH] D47995: [ASAN] fix startup crash in dlsym for long paths since glibc 2.27

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: compiler-rt/trunk/lib/asan/asan_malloc_linux.cc:53
+static void DeallocateFromLocalPool(const void *ptr) {
+  // Hack: since glibc 2.27, dlsym longer use stack-allocated memory to store
+  // error messages and instead use malloc followed by free. To avoid pool
----------------
Typo? s/dlsym longer/dlsym no longer/


================
Comment at: compiler-rt/trunk/lib/asan/asan_malloc_linux.cc:54
+  // Hack: since glibc 2.27, dlsym longer use stack-allocated memory to store
+  // error messages and instead use malloc followed by free. To avoid pool
+  // exhaustion due to long object filenames, handle that special case here.
----------------
Typo. s/use/uses/


Repository:
  rL LLVM

https://reviews.llvm.org/D47995