[PATCH] D48131: [RISCV] Implement codegen for cmpxchg on RV32I

[Tim Northover via Phabricator via llvm-commits]

t.p.northover added a comment.

I obviously haven't been following RISC-V enough to give final reviews, but this mostly looked sensible to me. Just one question:



================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:1744
+  Value *Addr = CI->getPointerOperand();
+  Value *AddrInt = Builder.CreatePtrToInt(Addr, Builder.getInt32Ty());
+  Value *AlignedAddr = Builder.CreateIntToPtr(
----------------
Is this an intentional choice not to support 64-bit pointers? Even if so, an assert might be good.


https://reviews.llvm.org/D48131