[PATCH] D48000: [InstSimplify]update simplifyUnsignedRangeCheck function's test case.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D48000#1130857, @HLJ2009 wrote:

> In https://reviews.llvm.org/D48000#1129677, @spatel wrote:
>
> > In https://reviews.llvm.org/D48000#1129644, @HLJ2009 wrote:
> >
> > > In https://reviews.llvm.org/D48000#1129641, @spatel wrote:
> > >
> > > > In https://reviews.llvm.org/D48000#1129208, @HLJ2009 wrote:
> > > >
> > > > > In https://reviews.llvm.org/D48000#1128454, @spatel wrote:
> > > > >
> > > > > > I think we've sorted out the problem in https://reviews.llvm.org/D47922, but this patch is not correct as shown.
> > > > > >
> > > > > > It should show the results (the missed optimization) that we currently get using trunk. Please update.
> > > > >
> > > > >
> > > > > Can you help me look at my submission? I use the trunk branch code.
> > > >
> > > >
> > > > In this patch, you want to add new tests to trunk (the code change from https://reviews.llvm.org/D47922 should not exist).
> > > >
> > > > Run utils/update_test_checks.py with these new tests. There should be at least one missed optimization in the CHECK lines (because https://reviews.llvm.org/D47922 is not applied).
> > >
> > >
> > > Yes, I want to do this. When this test file is accepted, I update https://reviews.llvm.org/D47922 again. Can I see the corresponding improvement ?
> >
> >
> > I don't understand. Are you unable to update **this** patch on Phabricator with the current CHECK lines?
>
>
>   sorroy, I know how to submit change to phabricator, but I don't know how to use utils/update_test_checks.py to get the difference file we want and set the test baseline. I made some attempts but it seems to be incorrect.




  $ cd llvm
  $ git checkout master # the svn trunk
  $ arc patch D48000 
  $ cd ../llvm-build/ # or whereever
  $ ninja
  $ ../llvm/utils/utils/update_test_checks.py --opt-binary ./bin/opt ../llvm/test/test/Transforms/InstSimplify/AndOrXor.ll
  $ git commit --amend
  $ git diff -p -U99999 master..arcpatch-D48000 > /tmp/patch.patch # i.e. from svn trunk to this commit
  $ # Update this differential with that patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D48000