[PATCH] D48000: [InstSimplify]update simplifyUnsignedRangeCheck function's test case.

Li Jia He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 13 04:19:08 PDT 2018


HLJ2009 added a comment.

In https://reviews.llvm.org/D48000#1129677, @spatel wrote:

> In https://reviews.llvm.org/D48000#1129644, @HLJ2009 wrote:
>
> > In https://reviews.llvm.org/D48000#1129641, @spatel wrote:
> >
> > > In https://reviews.llvm.org/D48000#1129208, @HLJ2009 wrote:
> > >
> > > > In https://reviews.llvm.org/D48000#1128454, @spatel wrote:
> > > >
> > > > > I think we've sorted out the problem in https://reviews.llvm.org/D47922, but this patch is not correct as shown.
> > > > >
> > > > > It should show the results (the missed optimization) that we currently get using trunk. Please update.
> > > >
> > > >
> > > > Can you help me look at my submission? I use the trunk branch code.
> > >
> > >
> > > In this patch, you want to add new tests to trunk (the code change from https://reviews.llvm.org/D47922 should not exist).
> > >
> > > Run utils/update_test_checks.py with these new tests. There should be at least one missed optimization in the CHECK lines (because https://reviews.llvm.org/D47922 is not applied).
> >
> >
> > Yes, I want to do this. When this test file is accepted, I update https://reviews.llvm.org/D47922 again. Can I see the corresponding improvement ?
>
>
> I don't understand. Are you unable to update **this** patch on Phabricator with the current CHECK lines?


sorroy, I know how to submit change to phabricator, but I don't know how to use utils/update_test_checks.py to get the difference file we want and set the test baseline. I made some attempts but it seems to be incorrect.


Repository:
  rL LLVM

https://reviews.llvm.org/D48000





More information about the llvm-commits mailing list