[PATCH] D47930: Make email options of find_interesting_reviews more flexible.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 08:52:18 PDT 2018


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM with Philip's comment addressed.



================
Comment at: utils/Reviewing/find_interesting_reviews.py:591
+        default="",
+        help="A comma separated list of email addresses to send the report to.")
+    parser.add_argument(
----------------
philip.pfaffe wrote:
> Instead of taking and parsing comma separated values, why not use `nargs='+'`.
> 
> On the other hand, it'd be nice to rename the option to '--email-report', which optionally takes email addresses. If none are given, just send it to the email addresses passed to the `email_addresses` option.
+1


Repository:
  rL LLVM

https://reviews.llvm.org/D47930





More information about the llvm-commits mailing list