[PATCH] D47930: Make email options of find_interesting_reviews more flexible.

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 11 02:45:04 PDT 2018


philip.pfaffe added inline comments.


================
Comment at: utils/Reviewing/find_interesting_reviews.py:591
+        default="",
+        help="A comma separated list of email addresses to send the report to.")
+    parser.add_argument(
----------------
Instead of taking and parsing comma separated values, why not use `nargs='+'`.

On the other hand, it'd be nice to rename the option to '--email-report', which optionally takes email addresses. If none are given, just send it to the email addresses passed to the `email_addresses` option.


Repository:
  rL LLVM

https://reviews.llvm.org/D47930





More information about the llvm-commits mailing list