[PATCH] D47900: AMDGPU: Error on LDS global address in functions

[Tony Tye via Phabricator via llvm-commits]

t-tye added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1279
 
-  if  (G->getAddressSpace() == AMDGPUASI.LOCAL_ADDRESS) {
+  if (G->getAddressSpace() == AMDGPUASI.LOCAL_ADDRESS) {
+    if (!MFI->isEntryFunction()) {
----------------
arsenm wrote:
> t-tye wrote:
> > Should this also give an error for any non-global address space? I think the same issue exists if global private or region address space happens. In that case therror message would be "global variables in non global address space not supported in non-kernel functions".
> This works fine for constant
But probably not for private (scratch) or region (GDS).


https://reviews.llvm.org/D47900