[PATCH] D47900: AMDGPU: Error on LDS global address in functions
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 8 01:06:32 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:1279
- if (G->getAddressSpace() == AMDGPUASI.LOCAL_ADDRESS) {
+ if (G->getAddressSpace() == AMDGPUASI.LOCAL_ADDRESS) {
+ if (!MFI->isEntryFunction()) {
----------------
t-tye wrote:
> Should this also give an error for any non-global address space? I think the same issue exists if global private or region address space happens. In that case therror message would be "global variables in non global address space not supported in non-kernel functions".
This works fine for constant
https://reviews.llvm.org/D47900
More information about the llvm-commits
mailing list