[PATCH] D47874: [SCEVExpander] Ignore dbg info when finding insertion point.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 7 12:49:31 PDT 2018


fhahn added a comment.

In https://reviews.llvm.org/D47874#1125474, @efriedma wrote:

> Not sure this is the best fix.  The function is named findInsertPointAfter; from the name, I would expect it to behave similarly to BasicBlock::getFirstInsertionPt (which does not try to move past debug info).
>
> We added instructionsWithoutDebug recently to deal with this sort of issue, but it's not directly usable here.


Yeah, maybe we should have a function that takes an iterator and advances the iterator to the first non debug/meta instruction?


https://reviews.llvm.org/D47874





More information about the llvm-commits mailing list