[PATCH] D47874: [SCEVExpander] Ignore dbg info when finding insertion point.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Not sure this is the best fix.  The function is named findInsertPointAfter; from the name, I would expect it to behave similarly to BasicBlock::getFirstInsertionPt (which does not try to move past debug info).

We added instructionsWithoutDebug recently to deal with this sort of issue, but it's not directly usable here.



================
Comment at: lib/Analysis/ScalarEvolutionExpander.cpp:95
 
-  while (isa<PHINode>(IP))
+  while (isa<PHINode>(IP) || isa<DbgInfoIntrinsic>(IP))
     ++IP;
----------------
This handling isn't consistent with the handling for landing pads/etc.


https://reviews.llvm.org/D47874