[PATCH] D47867: [PowerPC] avoid unprofitable Repl32 flag in BitPermutationSelector

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1455
+      // another bit group, we don't benefit from Repl32. We don't mark
+      // such group to give more freedom for later insrtruction selection.
+      if (BG.RLAmt == 0) {
----------------
insrtruction -> instruction


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1460
+            if (&BG != &BG2 && BG.V == BG2.V &&
+                (BG2.RLAmt == 0 || BG2.RLAmt == 32))
+              return true;
----------------
Don't you also need to check that the StartIdx or EndIdx is 0 or 32?


https://reviews.llvm.org/D47867