[PATCH] D47364: Change TII isCopyInstr way of returning arguments(NFC)
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 5 06:45:05 PDT 2018
arsenm added a comment.
In https://reviews.llvm.org/D47364#1122117, @NikolaPrica wrote:
> Yes. I agree. It would look prettier with reference. But we can't construct default MachineOperand like "MachineOperand MO;" and pass it to this isCopyInstr. We could construct it like "MachineOperand MO = MachineInstr::CreateReg();" but that is unnecessary object construction. Better way would be without need for object construction. Is my reasoning correct or am I missing something?
I would expect this to be a reference to pointer, not a pointer to pointer
https://reviews.llvm.org/D47364
More information about the llvm-commits
mailing list