[PATCH] D47364: Change TII isCopyInstr way of returning arguments(NFC)

Nikola Prica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 5 03:10:48 PDT 2018


NikolaPrica added a comment.

Yes. I agree. It would look prettier with reference. But we can't construct default MachineOperand like "MachineOperand MO;" and pass it to this isCopyInstr. We could construct it like "MachineOperand MO = MachineInstr::CreateReg();" but that is unnecessary object construction. Better way would be without need for object construction. Is my reasoning correct or am I missing something?


https://reviews.llvm.org/D47364





More information about the llvm-commits mailing list