[PATCH] D47763: [X86][NFC] Create zmm sched classes.
Clement Courbet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 5 06:14:37 PDT 2018
courbet added a comment.
In https://reviews.llvm.org/D47763#1122379, @RKSimon wrote:
> In https://reviews.llvm.org/D47763#1122107, @courbet wrote:
>
> > Note that this breaks scheduler tests for "GENERIC" , since we're using SNB. Is that fine ? Is there any situation where we would emit AVX512 but still use generic to schedule ?
>
>
> Sorry it's not fine. Specifying by ISA feature attribute and not cpu model is a common occurrence. SNB needs to "support" all scheduler classes.
That's what I was afraid of :(
How do we choose which scheduling info we want to use for SNB for unsupported instructions ? Do we just come up with something random ?
> My recommendation from https://reviews.llvm.org/D47721 was to not introduce any new classes in this new patch - it should purely be about flagging unsupported existing classes on each model.
OK: so each model **but** SNB, right ?
Repository:
rL LLVM
https://reviews.llvm.org/D47763
More information about the llvm-commits
mailing list