[PATCH] D47763: [X86][NFC] Create zmm sched classes.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In https://reviews.llvm.org/D47763#1122107, @courbet wrote:

> Note that this breaks scheduler tests for "GENERIC" , since we're using SNB. Is that fine ? Is there any situation where we would emit AVX512 but still use generic to schedule ?


Sorry it's not fine. Specifying by ISA feature attribute and not cpu model is a common occurrence. SNB needs to "support" all scheduler classes.

My recommendation from https://reviews.llvm.org/D47721 was to not introduce any new classes in this new patch - it should purely be about flagging unsupported existing classes on each model. https://reviews.llvm.org/D47721 would then be about adding the new ZMM classes.



================
Comment at: lib/Target/X86/X86SchedSandyBridge.td:99
 
+// Unsupported.
+let Unsupported = 1 in {
----------------
SNB is our generic model - we can't flag it as not supporting ANY instruction. Remove these entries and leave a note explaining why.


Repository:
  rL LLVM

https://reviews.llvm.org/D47763