[PATCH] D47463: [TableGen] Avoid leaking TreePatternNodes by using shared_ptr.

[David Blaikie via llvm-commits]

On Mon, Jun 4, 2018 at 1:58 PM Florian Hahn via Phabricator <
reviews at reviews.llvm.org> wrote:

> fhahn added a comment.
>
> Thanks you very much for looking at this carefully!


Sure thing - sorry if it's a bit nit-picky!


> I thought it was safer to start with a smaller diff,


Makes sense - sometimes I manage to front-load some of the API changes
(like changing functions from taking pointers to taking references -
updating the call sites from "f(x)" to "f(*x)") - that way the change to
smart pointers doesn't modify the call sites (no need to go from "f(x)" to
"f(x.get())"). But not always easy/obvious to do.


> but that it's in now and  I'll prepare a patch with your suggestions.
>

Sure - if you've got commit rights & feel sufficiently confident, you might
be able to make these changes incrementally & committing them directly
rather than waiting for review. If they're really small changes it can be a
lot easier to skim the commits than reviewing a big refactoring patch :)

- Dave


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D47463
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180604/e3cb6492/attachment.html>