[PATCH] D47741: Rename openFileForRead/Write to openFileDescriptorForRead/Write

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 4 13:29:11 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/unittests/Support/raw_pwrite_stream_test.cpp:86-87
 TEST(raw_pwrite_ostreamTest, TestDevNull) {
   int FD;
-  sys::fs::openFileForWrite("/dev/null", FD, sys::fs::F_None);
+  sys::fs::openFileDescriptorForWrite("/dev/null", FD, sys::fs::F_None);
   raw_fd_ostream OS(FD, true);
----------------
Oh dear, I'd forgotten about these old non Expected APIs. =(


https://reviews.llvm.org/D47741





More information about the llvm-commits mailing list