[PATCH] D47602: Correct aligment computation for shared object symbols

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:532-534
+  if (SS.Alignment == 0)
+    fatal("cannot create a copy relocation for symbol "
+          "with absolute address " + toString(SS));
----------------
shenhan wrote:
> ruiu wrote:
> > Can you really trigger this? Please always add a test when you add a new feature.
> No, from the discussion, this could never be triggered, otherwise this is a linker error.
> Replaced with assert.
We don't add use assert() that much in lld. Please just remove.


https://reviews.llvm.org/D47602