[PATCH] D47602: Correct aligment computation for shared object symbols

Han Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 1 14:09:34 PDT 2018


shenhan added inline comments.


================
Comment at: ELF/Relocations.cpp:532-534
+  if (SS.Alignment == 0)
+    fatal("cannot create a copy relocation for symbol "
+          "with absolute address " + toString(SS));
----------------
ruiu wrote:
> Can you really trigger this? Please always add a test when you add a new feature.
No, from the discussion, this could never be triggered, otherwise this is a linker error.
Replaced with assert.


https://reviews.llvm.org/D47602





More information about the llvm-commits mailing list