[PATCH] D41953: [LoopUnroll] Unroll and Jam
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 1 03:29:32 PDT 2018
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
Cleanup/simplification of the tests looks good to me. Just a nit inlined.
================
Comment at: lib/Transforms/Utils/LoopUnrollAndJam.cpp:543
+ // Update LoopInfo if the loop is completely removed.
+ if (CompletelyUnroll)
+ LI->erase(L);
----------------
If you move this to after the asserts, the other NDEBUG block , can you then move this statement:
Loop *OuterL = L->getParentLoop();
to inside the other #ifndef NDEBUG block? Thus we avoid having just one statement hash defined here.
https://reviews.llvm.org/D41953
More information about the llvm-commits
mailing list