[PATCH] D47379: [lld] Rename R_TLSGD/R_TLSLD to R_TLSGD_FROM_END/R_TLSLD_FROM_END [NFC]

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 28 01:57:07 PDT 2018


grimar added a comment.

New naming is confusing IMO. We had `R_GOTONLY_PC_FROM_END`, `R_GOT_FROM_END` and `R_GOTREL_FROM_END`.
Since names contains "GOT" it is clear that "FROM_END" says about the end of GOT.

But `R_TLSGD_FROM_END` is different made me think about the end of TLS first of all.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47379





More information about the llvm-commits mailing list