[PATCH] D47504: [AMDGPU] Simplify memory legalizer

[Tony Tye via Phabricator via llvm-commits]

t-tye marked an inline comment as done.
t-tye added inline comments.


================
Comment at: test/CodeGen/AMDGPU/memory-legalizer-invalid-addrspace.mir:3
+
+--- |
+  ; ModuleID = 'memory-legalizer-invalid-addrspace.ll'
----------------
arsenm wrote:
> t-tye wrote:
> > rampitec wrote:
> > > Could you strip mir test from all IR part?
> > The MMO references the IR to get the address space so I believe it is needed.
> The MMO should be able to support address spaces without an IR reference
Since the test is created from LLVM IR it seemed easier to leave the IR so the MMO is constructed with the correct address space. The alternative is to add an explicit address space to each MMO. This test follows the same approach of other existing tests, so if we want to change this we should also change those other tests.


https://reviews.llvm.org/D47504