[PATCH] D47573: {Power9} Enable extload of constant values to f128

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 31 00:46:22 PDT 2018


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:800
         setOperationAction(ISD::FP_EXTEND, MVT::f128, Legal);
-        setLoadExtAction(ISD::EXTLOAD, MVT::f128, MVT::f64, Expand);
-        setLoadExtAction(ISD::EXTLOAD, MVT::f128, MVT::f32, Expand);
+        for (MVT VT : MVT::fp_valuetypes())
+          setLoadExtAction(ISD::EXTLOAD, MVT::f128, VT, Expand);
----------------
Nit: please add a comment `// No extending loads to f128 on PPC.`


https://reviews.llvm.org/D47573





More information about the llvm-commits mailing list