[PATCH] D47561: [CMake] Unify handling of libxml2 with other libraries

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/test/lit.site.cfg.py.in:38
 config.have_libxar = @HAVE_LIBXAR@
+config.have_libxml2 = @HAVE_LIBXML2@
 config.have_dia_sdk = @LLVM_ENABLE_DIA_SDK@
----------------
delcypher wrote:
> Isn't  `@HAVE_LIBXML2@` going to expand to the string `TRUE`? That doesn't seem like it would work. First because it's not quoted, second because `config.have_libxml2` probably should be a python bool.
It'll because of `llvm_canonicalize_cmake_booleans`, see the change above in llvm/test/CMakeLists.txt.


Repository:
  rL LLVM

https://reviews.llvm.org/D47561