[PATCH] D47561: [CMake] Unify handling of libxml2 with other libraries

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:150
         include_directories(${LIBXML2_INCLUDE_DIR})
-        set(LIBXML2_LIBS "xml2")
       endif()
     endif()
----------------
If `LLVM_ENABLE_LIBXML2` is enabled but we don't find libxml2 then we should emit an error.


================
Comment at: llvm/test/lit.site.cfg.py.in:38
 config.have_libxar = @HAVE_LIBXAR@
+config.have_libxml2 = @HAVE_LIBXML2@
 config.have_dia_sdk = @LLVM_ENABLE_DIA_SDK@
----------------
Isn't  `@HAVE_LIBXML2@` going to expand to the string `TRUE`? That doesn't seem like it would work. First because it's not quoted, second because `config.have_libxml2` probably should be a python bool.


Repository:
  rL LLVM

https://reviews.llvm.org/D47561