[PATCH] D47485: [X86] Help update_llc_test_checks.py to recognise retl/retq to reduce CHECK duplication (PR35003)
Greg Bedwell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 29 10:04:01 PDT 2018
gbedwell added inline comments.
================
Comment at: utils/UpdateTestChecks/common.py:95
+ self.string = string
+ self.extrainfo = extrainfo
+ def __str__(self):
----------------
This isn't the most descriptive field name. Can you either rename to something more descriptive or add a comment to explain the nature of the info?
================
Comment at: utils/UpdateTestChecks/common.py:106
+ scrubbed_body = do_scrub(body, scrubber, scrubber_args, False)
+ scrubbed_extra = do_scrub(body, scrubber, scrubber_args, True)
if m.groupdict().has_key('analysis'):
----------------
raw Bool arguments aren't pretty. Please at least make it a named argument, e.g.
``` do_scrub(body, scrubber, scrubber_args, extra=False)```
Repository:
rL LLVM
https://reviews.llvm.org/D47485
More information about the llvm-commits
mailing list