[PATCH] D47485: [X86] Help update_llc_test_checks.py to recognise retl/retq to reduce CHECK duplication (PR35003)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon created this revision.
RKSimon added reviewers: MaskRay, gbedwell, spatel, craig.topper.

This patch replaces the --x86_extra_scrub command line argument to automatically support a second level of regex-scrubbing if it improves the matching of nearly-identical code patterns. The argument is still there to force extra matching if required.

This is mostly useful to help us share 32-bit/64-bit x86 vector tests which only differs by retl/retq instructions, but any scrubber can now technically support this, meaning test checks don't have to be needlessly obfuscated.

I've updated some of the existing checks that had been manually run with --x86_extra_scrub, to demonstrate the extra "ret{{[l|q]}}" scrub now only happens when useful, and re-run the sse42-intrinsics file to show extra matches - most sse/avx intrinsics files should be able to now share 32/64 checks.

Tested with the opt/analysis scripts as well which share common code - AFAICT the other update scripts use their own versions.


Repository:
  rL LLVM

https://reviews.llvm.org/D47485

Files:
  test/CodeGen/X86/avx-intrinsics-x86-upgrade.ll
  test/CodeGen/X86/avx-intrinsics-x86.ll
  test/CodeGen/X86/avx2-intrinsics-fast-isel.ll
  test/CodeGen/X86/packss.ll
  test/CodeGen/X86/sse42-intrinsics-fast-isel.ll
  utils/UpdateTestChecks/asm.py
  utils/UpdateTestChecks/common.py
  utils/update_llc_test_checks.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47485.148931.patch
Type: text/x-patch
Size: 57261 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180529/c2717f66/attachment.bin>