[PATCH] D44548: [DAGCombiner] Expand combining of FP logical operations to sign-setting FP operations

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 29 02:52:53 PDT 2018


RKSimon added a reviewer: RKSimon.
RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8933
+  // For vector nodes, the input must be a constant splat build vector and the
+  // splat value must be equal to SignMask.
+  if (IsVector) {
----------------
We have ISD::isConstOrConstSplat - can we use that instead and merge these 2 paths?


Repository:
  rL LLVM

https://reviews.llvm.org/D44548





More information about the llvm-commits mailing list