[PATCH] D47452: [NFC][X86][AArch64] Reorganize/cleanup BZHI test patterns

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 28 13:38:20 PDT 2018


lebedev.ri added inline comments.


================
Comment at: test/CodeGen/X86/bmi.ll:3
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+bmi | FileCheck %s --check-prefix=CHECK --check-prefix=BMI1
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+bmi,+bmi2 | FileCheck %s --check-prefix=CHECK --check-prefix=BMI2
 
----------------
RKSimon wrote:
> Should we add i686 test coverage for bmi?
Just duplicate every run line with 32-bit triple?
I'll defer to @craig.topper, since i don't know whether that would be useful.


Repository:
  rL LLVM

https://reviews.llvm.org/D47452





More information about the llvm-commits mailing list