[PATCH] D47452: [NFC][X86][AArch64] Reorganize/cleanup BZHI test patterns
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 28 11:13:24 PDT 2018
lebedev.ri added inline comments.
================
Comment at: test/CodeGen/AArch64/bmi-bzhi.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s
----------------
craig.topper wrote:
> bmi-bzhi doesn't make sense as a name for AArch64. Those are the names of X86 extensions. Someone familiar with AArch64, but not X86 would have no understanding of that.
Yes, indeed, i expected that feedback.
Should both of them be named something like `extract-low-bits.ll` ?
Repository:
rL LLVM
https://reviews.llvm.org/D47452
More information about the llvm-commits
mailing list