[PATCH] D47244: [llvm-mca] Add the RetireStage.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 18:05:44 PDT 2018


mattd updated this revision to Diff 148532.
mattd added a comment.
Herald added a subscriber: javed.absar.

I like Andrea's suggestion, and that we still maintain the RCU as a separate component.

This patch maintains that separation, but places ownership in the Backend.  Additionally, the RegisterFile (renamed to RF instead of RAT) is also another simulated hardware component that is owned by the Backend.  Any other MCA component that requires the use of such hardware abstraction will be passed pointers to those items during construction.  The Owner pointer in the RetireStage (sorry) will hopefully disappear once we move the eventing (notification) logic from solely being owned by the Backend, into the the Stages.

This patch moves the notifyInstructionRetired and cycleEvent from the RCU into the RetireStage.


https://reviews.llvm.org/D47244

Files:
  tools/llvm-mca/Backend.cpp
  tools/llvm-mca/Backend.h
  tools/llvm-mca/CMakeLists.txt
  tools/llvm-mca/DispatchStage.cpp
  tools/llvm-mca/DispatchStage.h
  tools/llvm-mca/RetireControlUnit.cpp
  tools/llvm-mca/RetireControlUnit.h
  tools/llvm-mca/RetireStage.cpp
  tools/llvm-mca/RetireStage.h
  tools/llvm-mca/Scheduler.cpp
  tools/llvm-mca/Scheduler.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47244.148532.patch
Type: text/x-patch
Size: 19271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180525/26431a6e/attachment.bin>


More information about the llvm-commits mailing list