[PATCH] D47325: [PPC64] Support the General-Dynamic tls relocations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, it needs a bit more time to understand the test though.



================
Comment at: ELF/Arch/PPC64.cpp:223
   switch (Type) {
+  case  R_PPC64_GOT_TLSGD16:
   case R_PPC64_TOC16:
----------------
extra space


================
Comment at: ELF/InputSection.cpp:634
            getAArch64Page(P);
   case R_TLSGD:
     return InX::Got->getGlobalDynOffset(Sym) + A - InX::Got->getSize();
----------------
sfertile wrote:
> Should `R_TLSGD` be renamed to `R_TLSGD_END` (likewise for R_TLSLD) to match the other RelExprs that subtract the got size off of  the TargetVA? I could do this in a separate nfc patch.
Yeah, I think so.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47325