[PATCH] D47325: [PPC64] Support the General-Dynamic tls relocations

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 24 11:47:12 PDT 2018


sfertile added inline comments.


================
Comment at: ELF/InputSection.cpp:634
            getAArch64Page(P);
   case R_TLSGD:
     return InX::Got->getGlobalDynOffset(Sym) + A - InX::Got->getSize();
----------------
Should `R_TLSGD` be renamed to `R_TLSGD_END` (likewise for R_TLSLD) to match the other RelExprs that subtract the got size off of  the TargetVA? I could do this in a separate nfc patch.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47325





More information about the llvm-commits mailing list