[PATCH] D45395: [RISCV] Lower the tail pseudoinstruction

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 23 13:56:34 PDT 2018


asb accepted this revision.
asb added a comment.

Fantastic, looks good to me (though see my comment for a tiny RISCVInstrInfo.td change to make prior to commit). Thanks!



================
Comment at: lib/Target/RISCV/RISCVInstrInfo.td:684-685
+          (PseudoTAIL texternalsym:$dst)>;
+def : Pat<(Tail GPRTC:$dst),
+          (PseudoTAILIndirect GPRTC:$dst)>;
+
----------------
This pattern isn't needed as it's already present in the PseudoTAILIndirect definition.


https://reviews.llvm.org/D45395





More information about the llvm-commits mailing list