[PATCH] D47114: [FileCheck] Implement -v and -vv for tracing matches

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: utils/FileCheck/FileCheck.cpp:98
+// helpful to FileCheck developers.
+//
+// First, it reports DAG directive matches that are discarded due to
----------------
probinson wrote:
> Again, getting too specific may become a maintenance issue.  The general motivation appears to be along the lines of "report things that FileCheck does or does not match, but which normally would not result in any output."
> 
Sure.  Two questions:

1. If I move each comment to the relevant VerboseVerbose check, that should eliminate the maintenance burden.  That would allow us to remember the rationale behind how I divided things between -v and -vv.  Then again, the rationale is now captured in phabricator, so I can just toss the comments if you prefer.  What do you think?

2. Is my understanding of the EOF pattern correct?  Specifically, is there any reason why the EOF pattern is needed after a DAG group?  Is that just an implementation convenience because DAGs and NOTs are stored together?

Thanks.


https://reviews.llvm.org/D47114