[PATCH] D47114: [FileCheck] Implement -v and -vv for tracing matches

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

The code changes look pretty tidy.  Let's sort out the `-vv` description and then we can call it good.



================
Comment at: docs/CommandGuide/FileCheck.rst:107
+  ``-v``.
+
 .. option:: --allow-deprecated-dag-overlap
----------------
I might not get so specific with the list of what gets printed; I'd prefer a broader statement of intent, maybe with specifics as examples.  Something like:

Print information helpful in diagnosing internal FileCheck issues; for example, discarded ...



================
Comment at: utils/FileCheck/FileCheck.cpp:98
+// helpful to FileCheck developers.
+//
+// First, it reports DAG directive matches that are discarded due to
----------------
Again, getting too specific may become a maintenance issue.  The general motivation appears to be along the lines of "report things that FileCheck does or does not match, but which normally would not result in any output."



https://reviews.llvm.org/D47114