[PATCH] D47188: Intel SVML calling conventions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:1485
+std::string TargetLibraryInfoImpl::getVectorizedFunction(StringRef F,
+                                                         unsigned VF, bool &FromSVML, bool IsFast) const {
+  FromSVML = ClVectorLibrary == SVML;
----------------
This looks like it passes 80 columns.


================
Comment at: lib/Analysis/TargetLibraryInfo.cpp:1501
   }
   return StringRef();
 }
----------------
This should probably be std::string() now.


================
Comment at: utils/TableGen/SVMLEmitter.cpp:51
+
+  unsigned MinSinglePrecVL = 4;
+  unsigned MaxSinglePrecVL = 16;
----------------
Mark these 'const'?


================
Comment at: utils/TableGen/SVMLEmitter.cpp:56
+
+  Record *SvmlVariantsClass = Records.getClass("SvmlVariant");
+  assert(SvmlVariantsClass &&
----------------
This looks to be a dead variable in release builds.


================
Comment at: utils/TableGen/SVMLEmitter.cpp:62
+
+  for (const auto &D : Records.getDefs()) {
+    std::string SvmlVariantNameStr = D.first;
----------------
I think this should be Records.getAllDerivedDefinitions("SvmlVariant")


Repository:
  rL LLVM

https://reviews.llvm.org/D47188