[PATCH] D47188: Intel SVML calling conventions

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: include/llvm/IR/SVML.td:53
+// While SVML doesn't provide _ha versions of
+// the following symbols let's disable their vectorization.
+
----------------
dvnagorny wrote:
> hfinkel wrote:
> > What does this mean? Why would a _ha variant of floor, for example, be needed for vectorization? Or, to put it another way, how would a _ha variant of floor differ from the _ep version?
> Really I don't expect any difference in behaviour, However I think that link-time weak aliases for these symbols are more preferable here. It will not require any additional logic in function name mangling code.
>  
Do these aliases exist currently? I'm concerned about the comment saying that we're disabling vectorization of floor, etc., and I'm prefer that we not disable vectorization unnecessarily.


Repository:
  rL LLVM

https://reviews.llvm.org/D47188