[PATCH] D47162: [WebAssembly] Initial support for LTO

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/LTO.cpp:57
+
+static void diagnosticHandler(const DiagnosticInfo &DI) {
+  SmallString<128> S;
----------------
sbc100 wrote:
> ruiu wrote:
> > Move this to Common/ErrorHandler.cpp.
> Is it OK for ErrorHandler.h to include llvm/IR/DiagnosticInfo.h ?   I was thinking of doing some followup changes to factor out some of the common LTO code.
Can't you just declare the class without including that header?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D47162