[PATCH] D47076: [InstCombine] choose 1 form of abs and nabs as canonical

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In https://reviews.llvm.org/D47076#1104961, @efriedma wrote:

> I guess it doesn't really matter what form you choose as canonical, given the backend will pattern-match it anyway, but "x > 0" seems like a weird choice; it can't be lowered to a sign-bit check like "x < 0".


Good point. I should make the code simpler if we always choose <0 too. Let me update.


https://reviews.llvm.org/D47076